Software Soft Skills

How one code review rule turned my team into a dream team

Interesting way of doing code reviews and getting a team across the code see here The Gist (Rules from this article)

  • Rule 1: Each Pull Request review must have at least 2 same-team developer approvals. Manager approval does not count.

  • Rule 2: Each Pull Request must have a good description. From reading the description, the reviewer should be able to understand what the code is meant to do. This has to be true even if there is a Jira ticket or a requirements page.

  • Rule 3: Pull Request must have sufficient unit test and integration test coverage.

  • Rule 4: If the Pull Request is a bug fix, it must contain a test such that, should the bug fix be reverted, this test would fail

I want to add something here on JIRA tickets